chore: remove csharp_namespace proto injection - #128
Merged
Anush008 merged 1 commit intoJul 29, 2026
Conversation
Upstream protos have carried option csharp_namespace since qdrant/qdrant#2952, so the fallback here no longer does anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
The protos downloaded from qdrant/qdrant have all carried
option csharp_namespacesince qdrant/qdrant#2952, so the injection in the DownloadProtos target is a no-op now. Removed it and thegrpcNamespaceconst it used.Checked that all 9 proto files downloaded at v1.18.0 have the option upstream. Ran
./build.sh build --overwrite-protosto force a fresh download through the changed path; format and build pass with no new warnings. Didn't run the Docker test suite locally, CI should cover it.